Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install binaries and overlay minor fixups #4369

Open
wants to merge 4 commits into
base: rolling
Choose a base branch
from
Open

Install binaries and overlay minor fixups #4369

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee233ef
makes more sense to update before upgrading
mikaelarguedas May 6, 2024
84ddab1
separate rosdep install calls to accomodate for installing RTI Connext
mikaelarguedas May 6, 2024
4be6b2e
leftover
mikaelarguedas May 6, 2024
7084ba1
Remove spurious empty line
mikaelarguedas May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions source/Installation/Alternatives/Ubuntu-Install-Binary.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,15 +81,37 @@ Instead you may download nightly :ref:`prerelease binaries <Prerelease_binaries>
Install dependencies using rosdep
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

.. code-block:: bash

sudo apt update

.. include:: ../_Apt-Upgrade-Admonition.rst

.. code-block:: bash

sudo apt update
sudo apt install -y python3-rosdep
sudo rosdep init
rosdep update
rosdep install --from-paths ~/ros2_{DISTRO}/ros2-linux/share --ignore-src -y --skip-keys "cyclonedds fastcdr fastrtps iceoryx_binding_c rmw_connextdds rti-connext-dds-6.0.1 urdfdom_headers"

.. tabs::

.. group-tab:: Fast DDS

.. code-block:: bash

rosdep install --from-paths ~/ros2_{DISTRO}/ros2-linux/share --ignore-src -y --skip-keys "cyclonedds fastcdr fastrtps iceoryx_binding_c rmw_connextdds rti-connext-dds-6.0.1 urdfdom_headers"

.. group-tab:: Cyclone DDS

.. code-block:: bash

rosdep install --from-paths ~/ros2_{DISTRO}/ros2-linux/share --ignore-src -y --skip-keys "cyclonedds fastcdr fastrtps iceoryx_binding_c rmw_connextdds rti-connext-dds-6.0.1 urdfdom_headers"

.. group-tab:: Connext DDS

.. code-block:: bash

rosdep install --from-paths ~/ros2_{DISTRO}/ros2-linux/share --ignore-src -y --skip-keys "cyclonedds fastcdr fastrtps iceoryx_binding_c rmw_connextdds urdfdom_headers"
Comment on lines +95 to +114
Copy link
Contributor

@clalancette clalancette May 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I love the group tabs here. The problem is that they are really all very similar, with only one difference.

My suggestion is different. I suggest that we restore line 92 to exactly how it was, and then just add a note that says something like:

.. note::

   If you are using Connext-DDS, you should install Connext with `sudo apt-get install rti-connext-dds-6.0.1`.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that they are really all very similar, with only one difference.

I saw little of the ROS 2 docs but most tabs I've seen so far were:
For Linux: command A
For macOS: command A
For Windows: command B

This seem very similar to the case here

I suggest that we restore line 92 to exactly how it was, and then just add a note that says something like:

Semantically it's a bit weird to me to says:
Step 1 "Run this long complex command blacklisting what you need"
Step 2 "Now if you need it: run this extra command to manually install the thing you just blacklisted".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahcorde should I apply #4369 (comment) ?
Or can this be merged as is ?


.. include:: ../_rosdep_Linux_Mint.rst

Expand Down
Loading