Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zenoh 1.0.0 Porting #276

Open
wants to merge 115 commits into
base: rolling
Choose a base branch
from
Open

Zenoh 1.0.0 Porting #276

wants to merge 115 commits into from

Conversation

YuanYuYuan
Copy link
Contributor

@YuanYuYuan YuanYuYuan commented Sep 5, 2024 •
edited
Loading

Notes

  • Remove some unused dependencies.
  • Use z_view_keyexpr_t rather z_owned_keyexpr_t if possible. This keeps the reference only and doesn't need to be dropped.
  • The attachment type has been removed. Use the plain z_bytes instead.
  • Attachment is nothing but z_bytes. Use an iterator to get value by key.
  • z_check is now internal. We check zenoh entities' health by the creation functions' return.

Mallets and others added 30 commits August 9, 2024 14:32
@Mallets @YuanYuYuan
Update style.yaml
e2fabb6 
Signed-off-by: Luca Cominardi <[email protected]>
@Mallets @YuanYuYuan
Update check_logging.yaml
6cd6dbe 
Signed-off-by: Luca Cominardi <[email protected]>
@Mallets @YuanYuYuan
Update build.yaml
dcefb68 
Signed-off-by: Luca Cominardi <[email protected]>
@YuanYuYuan
chore: configure the compiliation
14fe58c 
chore: checkout dev/1.0.0
@YuanYuYuan
chore: complete the 1st version
301a8ce
@YuanYuYuan
fix: memory leak
8ef92b5
@YuanYuYuan
wip
06b6fa4
@YuanYuYuan
fix: z_error_t -> z_result_t
71e7c5b
@fuzzypixelz @YuanYuYuan
Fix scouting/*/autoconnect/* per eclipse-zenoh/zenoh@b31a410 (#3)
a717270
@YuanYuYuan
chore: checkout the local zenoh-c
cfa63d9
@YuanYuYuan
chore: polish z_open
12dc820
@YuanYuYuan
fix: segfault
d331b74
@YuanYuYuan
feat: z_bytes_serialize_from_slice without copy
1db4bef
@YuanYuYuan
chore: switch back to https://github.com/eclipse-zenoh/zenoh-c
d12f189
@fuzzypixelz @YuanYuYuan
Initialize query_ member of ZenohQuery
909329b
@YuanYuYuan
refactor: use z_owned_slice_t instead
511c6f6
@YuanYuYuan
chore: adapt the latest change of zenoh-c dev/1.0.0
044d25b
@YuanYuYuan
chore: use strncmp to avoid copying
d79cf5e
@YuanYuYuan
refactor: use z_view_keyexpr_t to avoid copying
6637400
@YuanYuYuan
feat: implment the SHM feature
83334c8
@YuanYuYuan
chore: adpat the new changes from zenoh-c and fix the bug in liveliness
bf0da8a
@YuanYuYuan
fix: segmentation fault due to the unallocated query memory
dfc95ad
@YuanYuYuan
fix: workaround the ZID parsing issue
cd071e5
@yellowhatter @YuanYuYuan
fix Zenoh Config read\check
4f842fd
@yellowhatter @YuanYuYuan
adopt to recent zenoh-c API changes
af2e344
@YuanYuYuan
chore: sync up with the rolling branch
0225a59
@imstevenpmwork
chore: update to self-hosted runners
36140fd
@YuanYuYuan
fix: adapt the latest change of batching config
080eb15
@YuanYuYuan
Merge remote-tracking branch 'origin/rolling' into dev/1.0.0
f60c2a2
@YuanYuYuan
build: deprecate the zenohc_debug and incldue the zenohc dependency i…
83a26f2 
…n the zenoh_c_vendor
ahcorde
ahcorde requested changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to fix the conflicts?

@clalancette clalancette mentioned this pull request Oct 21, 2024
Closed
@ahcorde
Copy link
Contributor

ahcorde commented Oct 29, 2024

I'm working on this branch ahcorde/rolling/1.0.0_windows to support. For now I'm getting just segfaults in all rcl tests

evshary and others added 2 commits October 31, 2024 21:49
@evshary
Avoid touching Zenoh Session while exiting. (#37)
bb8e0ec 
* Avoid touching Zenoh Session while exiting.

Signed-off-by: ChenYing Kuo <[email protected]>

* Register function right after opening Zenoh Session.

Signed-off-by: ChenYing Kuo <[email protected]>

---------

Signed-off-by: ChenYing Kuo <[email protected]>
@YuanYuYuan
chore(deps): bump up zenoh-c to 1.0.1
787376c
ahcorde
ahcorde requested changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YuanYuYuan do you mind to update the code with the recent changes? there are some conflicts to resolve.

@alireza-moayyedi alireza-moayyedi mentioned this pull request Nov 7, 2024
Open
@ahcorde
Copy link
Contributor

ahcorde commented Nov 8, 2024

Windows failures are summarized in this comment

@Mallets Mallets mentioned this pull request Nov 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evshary evshary evshary left review comments

@Yadunund Yadunund Yadunund requested changes

@ahcorde ahcorde ahcorde requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.