add : get clients, servers info #771
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Minju, Lee <[email protected]>
This was referenced Jun 25, 2024
This was referenced Jun 25, 2024
fujitatomoya
reviewed
Jul 4, 2024
| @@ -123,4 +123,228 @@ __rmw_get_subscriptions_info_by_topic( | |||
| allocator, | |||
| subscriptions_info); | |||
| } | |||
|
|
|||
| rmw_ret_t | |||
| __rmw_get_clients_info_by_service( | |||
There was a problem hiding this comment.
this is related to ros2/ros2cli#916 (comment).
currently implementation fetches both writer and reader for 2 hidden topics and return them together.
on the other hand, when counting the service endpoints, it only checks mangled response hidden topic information. (e.g rmw_count_clients, it only counts the number of DataReader on response hidden topic.)
i think we can also align with this behavior for service endpoint information too because QoS information is the same with the other one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add get clients, servers info
Refer to ros2/ros2cli#916