Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an optional timeout_sec input to Client.call() to fix issue https://github.com/ros2/rclpy/issues/1181 #1188

Merged
merged 9 commits into from
Nov 17, 2023
Merged

Add an optional timeout_sec input to Client.call() to fix issue https://github.com/ros2/rclpy/issues/1181 #1188

merged 9 commits into from
Nov 17, 2023

Commits on Oct 17, 2023

  1. Add timeout_sec input to Client.call() to fix issue ros2#1181 

    Signed-off-by: KKSTB <[email protected]>
    @KKSTB
    KKSTB committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    e3a40c9 View commit details
    Browse the repository at this point in the history

  2. Add comment 

    Signed-off-by: KKSTB <[email protected]>
    @KKSTB
    KKSTB committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    584287e View commit details
    Browse the repository at this point in the history

  3. Add doc to the added timeout_sec param 

    Signed-off-by: KKSTB <[email protected]>
    @KKSTB
    KKSTB committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    2f9ce44 View commit details
    Browse the repository at this point in the history

  4. return of Client.call() should be Optional 

    Signed-off-by: KKSTB <[email protected]>
    @KKSTB
    KKSTB committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    d748ac1 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Merge branch 'ros2:rolling' into rolling

    @KKSTB
    KKSTB authored Nov 14, 2023
    Configuration menu
    Copy the full SHA
    bec12d6 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Add test cases for client sync call 

    Signed-off-by: KKSTB <[email protected]>
    @KKSTB
    KKSTB committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    d9a22d9 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. 1. Resolve flake8 formatting problems 

    2. Remove test_sync_call_slow()
3. Shorten test time

Signed-off-by: KKSTB <[email protected]>
    @KKSTB
    KKSTB committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    fe59e7c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ros2:rolling' into rolling

    @KKSTB
    KKSTB authored Nov 16, 2023
    Configuration menu
    Copy the full SHA
    1d86be6 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Fix flake8 warning 

    Signed-off-by: KKSTB <[email protected]>
    @KKSTB
    KKSTB committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    9d97c1e View commit details
    Browse the repository at this point in the history