-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement callback support of async_send_request for service generic client #2614
base: rolling
Are you sure you want to change the base?
Implement callback support of async_send_request for service generic client #2614
Conversation
…client Signed-off-by: Barry Xu <[email protected]>
Signed-off-by: Barry Xu <[email protected]>
@fujitatomoya would you be willing to give this one another review? 🧇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with green CI
@ahcorde could you have a 2nd review? |
Pulls: #2614 |
Currently, the implementation of
async_send_request
for the GenericClient lacks support for callbacks.When a response is received, the user-defined callback can be automatically invoked.