Add missing build_export_depend on rosidl_core_runtime (#165)

These four packages all export a dependency on rosidl_core_runtime in their CMakeLists.txt. They have an exec_depend, but since the dependency is needed for downstream packages to be built, it should also be a build_export_depend. Signed-off-by: Scott K Logan <[email protected]>
ros2 · Jun 22, 2024 · 4959b5d · 4959b5d
1 parent 011c875
commit 4959b5d
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/action_msgs/package.xml b/action_msgs/package.xml
@@ -17,6 +17,8 @@
   <buildtool_depend>ament_cmake</buildtool_depend>
   <buildtool_depend>rosidl_core_generators</buildtool_depend>
 
+  <build_export_depend>rosidl_core_runtime</build_export_depend>
+
   <depend>builtin_interfaces</depend>
   <depend>service_msgs</depend>
   <depend>unique_identifier_msgs</depend>

diff --git a/builtin_interfaces/package.xml b/builtin_interfaces/package.xml
@@ -14,9 +14,10 @@
   <author email="[email protected]">Michel Hidalgo</author>
 
   <buildtool_depend>ament_cmake</buildtool_depend>
-
   <buildtool_depend>rosidl_core_generators</buildtool_depend>
 
+  <build_export_depend>rosidl_core_runtime</build_export_depend>
+
   <exec_depend>rosidl_core_runtime</exec_depend>
 
   <test_depend>ament_lint_common</test_depend>

diff --git a/service_msgs/package.xml b/service_msgs/package.xml
@@ -14,6 +14,8 @@
   <buildtool_depend>ament_cmake</buildtool_depend>
   <buildtool_depend>rosidl_core_generators</buildtool_depend>
 
+  <build_export_depend>rosidl_core_runtime</build_export_depend>
+
   <depend>builtin_interfaces</depend>
 
   <exec_depend>rosidl_core_runtime</exec_depend>

diff --git a/type_description_interfaces/package.xml b/type_description_interfaces/package.xml
@@ -10,9 +10,10 @@
   <license>Apache License 2.0</license>
 
   <buildtool_depend>ament_cmake</buildtool_depend>
-
   <buildtool_depend>rosidl_core_generators</buildtool_depend>
 
+  <build_export_depend>rosidl_core_runtime</build_export_depend>
+
   <depend>service_msgs</depend>
 
   <exec_depend>rosidl_core_runtime</exec_depend>