Revert "improved rcl_wait in the area of timeout computation and spur… #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's a full CI run on Linux on the current code: And here is full CI with it reverted (i.e. this PR applied):
|
|
@clalancette can you run the CI with #1143 ? |
|
I played around with #1143 a bit but was unable to fix all the tests with it. I think it's a good start, but in order to avoid these tests failing over the weekend, I'm going to go forward with this revert and then work on re-reverting it next week with a fix like #1143. Note the tests that failed in #1142 (comment) are known flakes that are (in my opinion) unrelated to this change. |
|
Follow up CI for rolling, to see that this was effective post merge:
|
This was referenced Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ious wakeups (#1135)"
This reverts commit 3c6c5dc.
The combination of this and ros2/rclcpp#2142 seems to be causing regressions on the buildfarm; see https://ci.ros2.org/job/ci_linux/20668/#showFailuresLink for the results.
For now, let's revert this one to get CI back to green. @mjcarroll @wjwwood @jmachowinski FYI