Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the various 'is_valid' calls #1086

Draft
wants to merge 9 commits into
base: rolling
Choose a base branch
from
Draft

Simplify the various 'is_valid' calls #1086

wants to merge 9 commits into from

Commits on Aug 6, 2023

  1. Refactor rcl_subscription_is_valid. 

    Users should be able to query whether a subscription
is valid without having an error set.  Only set an
error if an invalid pointer (e.g. NULL) was passed in.

Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    9aab2a8 View commit details
    Browse the repository at this point in the history

  2. Simplify rcl_client_is_valid. 

    A user should be able to query whether a client is
valid without an error being set.  Fix that here.

Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    97ddf0b View commit details
    Browse the repository at this point in the history

  3. Simplify rcl_event_is_valid. 

    A user should be able to query whether an event is
valid without an error being set.  Fix that here.

Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    860ab94 View commit details
    Browse the repository at this point in the history

  4. Simplify rcl_node_is_valid. 

    A user should be able to query whether a node is
valid without setting an error.  Fix that here.

Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    8e23cd1 View commit details
    Browse the repository at this point in the history

  5. Simplify rcl_publisher_is_valid. 

    A user should be able to query whether a publisher is
valid without it setting an error.  Fix that here.

Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    d7e6664 View commit details
    Browse the repository at this point in the history

  6. Simplify rcl_service_is_valid. 

    A user should be able to query whether a service is
valid without it setting an error.  Fix that here.

Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    f805b97 View commit details
    Browse the repository at this point in the history

  7. Simplify rcl_service_event_publisher_is_valid. 

    A user should be able to query whether a service event
publisher is valid without it setting an error.  Fix
that here.

Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    a77b3c9 View commit details
    Browse the repository at this point in the history

  8. Cleanup rcl_wait_set_is_valid. 

    A user should be able to query whether a wait_set is
valid without it setting an error, which it already does.
However, passing a NULL into it is logically invalid;
we can't possibly answer that question.  So set an error
in that case.

Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    5ede8a8 View commit details
    Browse the repository at this point in the history

  9. Fixes after CI. 

    Signed-off-by: Chris Lalancette <[email protected]>
    @clalancette
    clalancette committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    43f41dd View commit details
    Browse the repository at this point in the history