-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds an input aligner filter #148
base: rolling
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your great contribution, I did an initial pass, I will do a deeper review, meanwhile I would love to have more eyes here. @clalancette do you mind to take a look ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind to add some documentation about this new feature under the doc
folder ?
Pulls: #148 |
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Pulls: #148 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind to take a look to the new windows warnings ? https://ci.ros2.org/job/ci_windows/22677/msbuild/new/
@saarnold friendly ping |
This adds a new message filter implementation allowing to align multiple inputs in time and calling their callbacks in the right order.
This filter aims to handle the common case in which messages on different input streams arrive with different delays, due to processing times or the used transport channel.
This is a feature that was missing so far.