Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an input aligner filter #148

Open
wants to merge 4 commits into
base: rolling
Choose a base branch
from

Conversation

saarnold
Copy link

This adds a new message filter implementation allowing to align multiple inputs in time and calling their callbacks in the right order.
This filter aims to handle the common case in which messages on different input streams arrive with different delays, due to processing times or the used transport channel.
This is a feature that was missing so far.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great contribution, I did an initial pass, I will do a deeper review, meanwhile I would love to have more eyes here. @clalancette do you mind to take a look ?

test/test_input_aligner.cpp Show resolved Hide resolved
test/test_input_aligner.cpp Show resolved Hide resolved
test/test_input_aligner.cpp Show resolved Hide resolved
test/test_input_aligner.cpp Show resolved Hide resolved
include/message_filters/input_aligner.hpp Show resolved Hide resolved
include/message_filters/input_aligner.hpp Show resolved Hide resolved
include/message_filters/input_aligner.hpp Show resolved Hide resolved
include/message_filters/input_aligner.hpp Show resolved Hide resolved
include/message_filters/input_aligner.hpp Show resolved Hide resolved
include/message_filters/input_aligner.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to add some documentation about this new feature under the doc folder ?

@ahcorde
Copy link
Contributor

ahcorde commented Oct 4, 2024

Pulls: #148
Gist: https://gist.githubusercontent.com/ahcorde/a884db5657005fa29d85aedc926e6297/raw/44615e18a54c5f9df888d0fe3486f93401824ff5/ros2.repos
BUILD args: --packages-above-and-dependencies message_filters --packages-above-and-dependencies message_filters
TEST args: --packages-above message_filters --packages-above message_filters
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14663

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde
Copy link
Contributor

ahcorde commented Oct 4, 2024

Pulls: #148
Gist: https://gist.githubusercontent.com/ahcorde/74f63f0464d1cfe65afbb106fac8f00b/raw/44615e18a54c5f9df888d0fe3486f93401824ff5/ros2.repos
BUILD args: --packages-above-and-dependencies message_filters --packages-above-and-dependencies message_filters
TEST args: --packages-above message_filters --packages-above message_filters
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14665

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to take a look to the new windows warnings ? https://ci.ros2.org/job/ci_windows/22677/msbuild/new/

@ahcorde
Copy link
Contributor

ahcorde commented Oct 14, 2024

@saarnold friendly ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants