Bugfix/segfault when getting surrounding interval of empty cache (backport #116) #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a segfault that occurred to me when I tried to get a surrounding interval from a
message_filter::Cache
that was empty. See comment below for where/how.The PR includes
Is it possible to get the fix also to other branches, specifically
humble
(butiron
would probably also make sense)? That's the version I am using at the moment. I think the fix commit should be cherry-pickable. But the test commit probably needs some minor adaptation due to namespace changes.Please let me know if I need to follow some specific procedure or provide more information for contributing (e.g. create issue first, or similar).
This is an automatic backport of pull request #116 done by Mergify.