Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/segfault when getting surrounding interval of empty cache (backport #116) #141

Open
wants to merge 1 commit into
base: jazzy
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 1, 2024

This PR fixes a segfault that occurred to me when I tried to get a surrounding interval from a message_filter::Cache that was empty. See comment below for where/how.

The PR includes

  • a test that should reproduce the segfault when executed without the fix.
  • the fix of the segfault

Is it possible to get the fix also to other branches, specifically humble (but iron would probably also make sense)? That's the version I am using at the moment. I think the fix commit should be cherry-pickable. But the test commit probably needs some minor adaptation due to namespace changes.

Please let me know if I need to follow some specific procedure or provide more information for contributing (e.g. create issue first, or similar).


This is an automatic backport of pull request #116 done by Mergify.

(cherry picked from commit e60450d)

# Conflicts:
#	include/message_filters/cache.hpp
@mergify mergify bot added the conflicts label Aug 1, 2024
@mergify mergify bot requested a review from gbiggs as a code owner August 1, 2024 16:12
Copy link
Author

mergify bot commented Aug 1, 2024

Cherry-pick of e60450d has failed:

On branch mergify/bp/jazzy/pr-116
Your branch is up to date with 'origin/jazzy'.

You are currently cherry-picking commit e60450d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   test/msg_cache_unittest.cpp

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   include/message_filters/cache.hpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants