Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rosdep key for minijinja #43391

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Conversation

JafarAbdi
Copy link
Contributor

Please add the following dependency to the rosdep database.

Package name:

minijinja

Package Upstream Source:

https://github.com/mitsuhiko/minijinja/tree/main/minijinja-py

Purpose of using this:

A powerful template engine for Python

Distro packaging links:

Links to Distribution Packages

@JafarAbdi JafarAbdi requested a review from a team as a code owner November 8, 2024 11:48
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Nov 8, 2024
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it looks like minijinja is available in Debian Trixie and later, as well as Ubuntu Oracular and later. So we should rename the key to python3-minijinja, put the system dependencies in there, and mark the rest as pip installable.

@JafarAbdi
Copy link
Contributor Author

So it looks like minijinja is available in Debian Trixie and later, as well as Ubuntu Oracular and later. So we should rename the key to python3-minijinja, put the system dependencies in there, and mark the rest as pip installable.

Thanks! I wasn't aware of that, I updated the keys

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating!

@clalancette clalancette merged commit 4c7c9ea into ros:master Nov 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants