Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libfranka package #42433

Merged
merged 1 commit into from
Sep 20, 2024
Merged

add libfranka package #42433

merged 1 commit into from
Sep 20, 2024

Conversation

winkma
Copy link
Contributor

@winkma winkma commented Aug 13, 2024

Please Add This Package to be indexed in the rosdistro.

distribution: humble
package name: libfranka

This package is required to control Franka Robotics research robots.

The source is here:

https://github.com/frankaemika/libfranka.git

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

@github-actions github-actions bot added the humble Issue/PR is for the ROS 2 Humble distribution label Aug 13, 2024
humble/distribution.yaml Outdated Show resolved Hide resolved
@mjcarroll
Copy link
Member

I notice that there is not a package.xml in this package. How is expected that this software is built and packaged? Are you intending to introduce a vendor package?

@mjcarroll mjcarroll added the more information needed Maintainers have asked for additional information label Aug 15, 2024
@winkma
Copy link
Contributor Author

winkma commented Aug 20, 2024

I notice that there is not a package.xml in this package. How is expected that this software is built and packaged?

There is no package.xml yet, because for older ROS1 releases, it used to come from our libfranka-release repository. However, we would like to do things the recommended way for ROS2, so we can add a package.xml in libfranka. Would you recommend us to do so?

Are you intending to introduce a vendor package?

What exactly do you mean by a vendor package?

@winkma
Copy link
Contributor Author

winkma commented Aug 23, 2024

We've added the package.xml now 👍 . We don't want to introduce a vendor package.

@winkma
Copy link
Contributor Author

winkma commented Sep 9, 2024

Hi there! Do you have any more input for us? Do the package.xml and the PR in general look ok to you?

@nuclearsandwich
Copy link
Member

New package review:

@nuclearsandwich
Copy link
Member

Closing and re-opening to kick-over GitHub Actions. It's become super flaky recently.

@nuclearsandwich nuclearsandwich merged commit 5a13e1f into ros:master Sep 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
humble Issue/PR is for the ROS 2 Humble distribution more information needed Maintainers have asked for additional information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants