Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PySide6 to rosdep keys #42353

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add PySide6 to rosdep keys #42353

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
383f99e
Added PySide6 with pip.
samyarsadat Aug 8, 2024
dc9d4ff
Removed incorrectly added quotation marks.
samyarsadat Aug 8, 2024
b5078d3
Scoped PySide6 to specific OSes and versions.
samyarsadat Aug 12, 2024
1aba436
Fixed alphabetical order.
samyarsadat Aug 12, 2024
ce6a3a9
Add PySide6 system packages for Ubuntu Oracular & Debian Sid.
samyarsadat Aug 29, 2024
590b6ae
Add trixie definitions for pyside6.
nuclearsandwich Sep 19, 2024
cb03009
Change sort order.
nuclearsandwich Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 85 additions & 0 deletions rosdep/python.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8442,6 +8442,91 @@
'*': [python3-pyside2]
'8': null
ubuntu: [python3-pyside2.qtwidgets]
python3-pyside6:
debian:
bookworm:
pip:
packages: [PySide6]
bullseye:
pip:
packages: [PySide6]
sid: [libpyside6-dev]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sid: [libpyside6-dev]
trixie: [libpyside6-dev]
sid: [libpyside6-dev]

Add the current Debian Testing distribution as well. I would even consider dropping the sid definition altogether in favor of just trixie but don't mind it being there.

It's worth making the change for each of the definitions below as well.

Copy link
Member

@nuclearsandwich nuclearsandwich Sep 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 590b6ae

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this made CI unhappy

    ERR: list out of alphabetical order line 8526.  'sid' should come before 'trixie'
    ERR: list out of alphabetical order line 8551.  'sid' should come before 'trixie'
    ERR: list out of alphabetical order line 8557.  'sid' should come before 'trixie'
    ERR: list out of alphabetical order line 8563.  'sid' should come before 'trixie'
    ERR: list out of alphabetical order line 8569.  'sid' should come before 'trixie'
    ERR: list out of alphabetical order line 8575.  'sid' should come before 'trixie'
    ERR: list out of alphabetical order line 8581.  'sid' should come before 'trixie'
    ERR: list out of alphabetical order line 8587.  'sid' should come before 'trixie'
    ERR: list out of alphabetical order line 8593.  'sid' should come before 'trixie'
    ERR: list out of alphabetical order line 8599.  'sid' should come before 'trixie'

trixie: [libpyside6-dev]
osx:
pip:
packages: [PySide6]
rhel:
'8':
pip:
packages: [PySide6]
'9':
pip:
packages: [PySide6]
ubuntu:
focal:
pip:
packages: [PySide6]
jammy:
pip:
packages: [PySide6]
noble:
pip:
packages: [PySide6]
oracular: [libpyside6-dev]
python3-pyside6.qtasyncio:
debian:
sid: [python3-pyside6.qtasyncio]
trixie: [python3-pyside6.qtasyncio]
ubuntu:
oracular: [python3-pyside6.qtasyncio]
python3-pyside6.qtcharts:
debian:
sid: [python3-pyside6.qtcharts]
trixie: [python3-pyside6.qtcharts]
ubuntu:
oracular: [python3-pyside6.qtcharts]
python3-pyside6.qtconcurrent:
debian:
sid: [python3-pyside6.qtconcurrent]
trixie: [python3-pyside6.qtconcurrent]
ubuntu:
oracular: [python3-pyside6.qtconcurrent]
python3-pyside6.qtcore:
debian:
sid: [python3-pyside6.qtcore]
trixie: [python3-pyside6.qtcore]
ubuntu:
oracular: [python3-pyside6.qtcore]
python3-pyside6.qtdatavisualization:
debian:
sid: [python3-pyside6.qtdatavisualization]
trixie: [python3-pyside6.qtdatavisualization]
ubuntu:
oracular: [python3-pyside6.qtdatavisualization]
python3-pyside6.qtgui:
debian:
sid: [python3-pyside6.qtgui]
trixie: [python3-pyside6.qtgui]
ubuntu:
oracular: [python3-pyside6.qtgui]
python3-pyside6.qtqml:
debian:
sid: [python3-pyside6.qtqml]
trixie: [python3-pyside6.qtqml]
ubuntu:
oracular: [python3-pyside6.qtqml]

Check warning on line 8517 in rosdep/python.yaml

View workflow job for this annotation

GitHub Actions / rosdistro / rosdep checks (3.8) 

Key 'python3-pyside6' might be satisfied by fedora package named 'python3-pyside6': https://mirrors.rit.edu/fedora/fedora/linux/updates/40/Everything/x86_64/Packages/p/python3-pyside6-6.7.2-4.fc40.i686.rpm
python3-pyside6.qttest:
debian:
sid: [python3-pyside6.qttest]
trixie: [python3-pyside6.qttest]
ubuntu:
oracular: [python3-pyside6.qttest]
python3-pyside6.qtwidgets:
debian:
sid: [python3-pyside6.qtwidgets]
trixie: [python3-pyside6.qtwidgets]
ubuntu:
oracular: [python3-pyside6.qtwidgets]
python3-pysnmp:
debian: [python3-pysnmp4]
fedora: [python3-pysnmp]
Expand Down
Loading