Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etsi_its_messages: 2.0.2-2 in 'jazzy/distribution.yaml' [bloom] #41709

Closed
wants to merge 1 commit into from

Conversation

jpbusch
Copy link
Contributor

@jpbusch jpbusch commented Jun 17, 2024

We have noticed that for some of our packages the dependencies have not all been released for jazzy yet. To prevent the buildfarm from failing all the time, we have removed the corresponding packages here for now.

Increasing version of package(s) in repository etsi_its_messages to 2.0.2-2:

etsi_its_cam_coding

  • No changes

etsi_its_cam_conversion

  • No changes

etsi_its_cam_msgs

  • No changes

etsi_its_coding

  • No changes

etsi_its_conversion

  • No changes

etsi_its_denm_coding

  • No changes

etsi_its_denm_conversion

  • No changes

etsi_its_denm_msgs

  • No changes

etsi_its_messages

  • No changes

etsi_its_msgs

  • No changes

etsi_its_msgs_utils

  • No changes

etsi_its_primitives_conversion

  • No changes

etsi_its_rviz_plugins

  • No changes

@github-actions github-actions bot added the jazzy Issue/PR is for the ROS 2 Jazzy distribution label Jun 17, 2024
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is allowed, but note that this will remove many of the packages associated with this repository. Thus, any users that already have this installed will never get another update. This is particularly odd given that this is just a debinc bump, and not a new release from upstream.

Please let us know if this is what you intended.

@marcoag marcoag self-assigned this Jun 19, 2024
@marcoag marcoag added the more information needed Maintainers have asked for additional information label Jun 19, 2024
Copy link

github-actions bot commented Jul 4, 2024

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale Issue/PR hasn't been active in a while and may be closed. label Jul 4, 2024
@jpbusch
Copy link
Contributor Author

jpbusch commented Jul 5, 2024

Sorry for the late response. We have decided not to merge this PR as we will be releasing a new version soon anyway.

However, we still have one question. The buildfarm currently always fails with this error (all packages - jazzy). Can you tell us the reason for this and how we can avoid it for the next release?

@github-actions github-actions bot removed the stale Issue/PR hasn't been active in a while and may be closed. label Jul 5, 2024
@marcoag
Copy link
Contributor

marcoag commented Jul 5, 2024

However, we still have one question. The buildfarm currently always fails with this error (all packages - jazzy). Can you tell us the reason for this and how we can avoid it for the next release?

It seems like the command

git clone --branch debian/ros-jazzy-etsi-its-conversion_2.0.2-1_noble --depth 1 --no-single-branch https://github.com/ros2-gbp/etsi_its_messages-release.git /tmp/sourcedeb/source

is failing to find the ref. Meaning debian/ros-jazzy-etsi-its-conversion_2.0.2-1_noble is not present in the release repo. If I look in the repo I can only find the tag debian/ros-jazzy-etsi-its-conversion_2.0.2-2_noble but not the -1 version which tells me some bloom-release might have failed half way and then a second one was done but for some reason the version that ended up in the rosdistro is the 2.0.2-1. Updating the rosdistro version to 2.0.2-2 might help solve the issue, but make sure this is ok with the other packages in the repo. Alternatively you could just re-bloom.

Closing this PR as requested and since a new version is coming. 🚀

@marcoag marcoag closed this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jazzy Issue/PR is for the ROS 2 Jazzy distribution more information needed Maintainers have asked for additional information
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants