Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename gc_spl to game_controller_spl in rolling #40707

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

ijnek
Copy link
Contributor

@ijnek ijnek commented Apr 20, 2024

As requested in #40578, splitting up the changes into PR per distro.

Repository was renamed recently from gc_spl to game_controller_spl. Instead of updating the name just for rolling's distribution.yaml, for consistency, I updated the names in humble and iron's distribution files too. I'm hoping there are no issues with this manual change.

Related issue in ros2-gbp

@github-actions github-actions bot added the rolling Issue/PR is for the ROS 2 Rolling distribution label Apr 20, 2024
@mjcarroll mjcarroll added the held for coordinated release Issue/PR has been held because it requires additional releases label Apr 22, 2024
@clalancette
Copy link
Contributor

This one will need to be rebased to fix the conflict. After that, we can see what CI doesn't like about it.

@ijnek
Copy link
Contributor Author

ijnek commented Apr 27, 2024

Rebased this PR. The diff isn't great, but should be correct.

Signed-off-by: ijnek <[email protected]>
@ijnek
Copy link
Contributor Author

ijnek commented Apr 28, 2024

The CI failure was due to tags being pushed to the old release repo during the jazzy split off, but these tags didn't exist in the new release repository. I've updated the version to match the latest ones on the new release repo.

@clalancette clalancette merged commit f8005d6 into ros:master Apr 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
held for coordinated release Issue/PR has been held because it requires additional releases rolling Issue/PR is for the ROS 2 Rolling distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants