Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_relay: 1.0.1-1 in 'melodic/distribution.yaml' [bloom] #37716

Closed
wants to merge 1 commit into from

Conversation

peci1
Copy link
Contributor

@peci1 peci1 commented Jun 19, 2023

Increasing version of package(s) in repository http_relay to 1.0.1-1:

http_relay

* Noetic compatibility.
* Added sigkill_on_stream_stop so that the relay is only killed if there is a stale request.
* Added sigkill_timeout for automatic restarting of the node even if it hangs on a connection.
* Support NTRIP in Python 3
* Fix Python3 NTRIP relay.
* Initial commit.
* Contributors: Martin Pecka

@github-actions github-actions bot added the melodic Issue/PR is for the ROS 1 Melodic distribution label Jun 19, 2023
@@ -4595,6 +4595,21 @@ repositories:
url: https://github.com/fkanehiro/hrpsys-base.git
version: master
status: maintained
http_relay:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is another name that I think is pretty generic, and I'm actually not sure at all why it needs to be a ROS package. That is, it really just reverse proxies HTTP requests, and the only thing it seems to use ROS for is to get parameters from the global parameter server. It seems to me that this functionality could just be satisfied by pip installing a Python package.

That said, I could be missing something about how it operates, so feel free to correct me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this functionality isn't directly ROS-related. But it is robot-related. A few times we had devices which could not access outer networks directly.

I searched the whole apt and pip, but i haven't found any simple package for http proxying (except for big beefy frameworks).

And as it wasn't the first time we needed to run a http relay on the robots, I felt this would be a good package candidate.

Our latest use-case is directly embedding the proxy into sensor ROS driver.

I think this package follows the naming REP. The name clearly says what it does. Name collisions don't matter because any other package trying to achieve similar functionality would basically do the same. And org prefix doesn't make sense because there is nothing org-specific there.

@adityapande-1995 adityapande-1995 added the changes requested Maintainers have asked for changes to the pull request label Jun 20, 2023
@mjcarroll mjcarroll added the held for sync Issue/PR has been held because the distribution is in a sync hold label Jun 21, 2023
@clalancette
Copy link
Contributor

Since Melodic is now EOL, closing this out. I've reproduced the conversation above into #37717.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request held for sync Issue/PR has been held because the distribution is in a sync hold melodic Issue/PR is for the ROS 1 Melodic distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants