Add aiortc #33726
Merged
Add aiortc #33726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hidmic
reviewed
Jun 30, 2022
rosdep/python.yaml
Outdated
| packages: [aiortc] | ||
| ubuntu: | ||
| pip: | ||
| packages: [aiortc] |
There was a problem hiding this comment.
@Interpause I see python3-aiortc available in several platform specific package managers (e.g. Debian, Ubuntu).
Consider adding a python3-aiortc key referring those wherever applicable.
There was a problem hiding this comment.
We generally prefer system packages over pip : https://github.com/ros/rosdistro/blob/master/CONTRIBUTING.md
nuclearsandwich
previously requested changes
Jul 8, 2022
Co-authored-by: Steven! Ragnarök <[email protected]>
jacobperron
reviewed
Jul 13, 2022
tfoote
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add the following dependency to the rosdep database.
Package name:
aiortcPackage Upstream Source:
https://github.com/aiortc/aiortc
Purpose of using this:
aiortcis a Python implementation of the WebRTC protocol, including support for DataChannels. Notably, it doesn't depend on the Chromium WebRTC project, hence avoiding issues such as RobotWebTools/webrtc_ros#66. WebRTC is not only useful for sending video data to a browser from a robot, but also low latency realtime data via datachannels. Hence, I think it is valuable to add this to the index.Distro packaging links:
Links to Distribution Packages