draw over ranged data #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
reviewed
Oct 8, 2018
src/rqt_plot/rosplot.py
Outdated
| else: | ||
| for f in self.field_evals: | ||
| val = f(val) | ||
| self.error = None |
There was a problem hiding this comment.
Maybe the error should be reset in the _ros_cb method after acquiring the lock instead?
There was a problem hiding this comment.
@dirk-thomas Thank you for the comment! Updated the commit.
furushchev
force-pushed
the
index-error
branch
from
f544ead
to
f6ca418
Compare
furushchev
force-pushed
the
index-error
branch
from
f6ca418
to
1264197
Compare
|
Resolved conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
rqt_plotdoes not plot over ranged data in an array.For example, with the message like below:
and when I set the first and second index of the data as plotted topics
rqt_plotshows the first data.And then if I publish data which contains 2 float data like below:
The data
/pub_topic/data[1]is never plotted.This pull request fixes this error.
With this pull request,
rqt_plotimmediately draws whenever the data is available.