Remove edge simplification from node-only graph. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when there were multiple topics between two nodes, only one of the topics was being displayed. This was caused by graph simplification flag not being passed into the edge-adding code. Graph simplification was also defaulting to True, when in fact it should be false for the node-to-node graph.
vpradeep07
commented
Nov 15, 2018
| @@ -304,6 +304,7 @@ def _generate_dotcode(self): | |||
| hide_tf_nodes = self._widget.hide_tf_nodes_check_box.isChecked() | |||
| group_image_nodes = self._widget.group_image_check_box.isChecked() | |||
| hide_dynamic_reconfigure = self._widget.hide_dynamic_reconfigure_check_box.isChecked() | |||
| simplify = (graph_mode != NODE_NODE_GRAPH) | |||
There was a problem hiding this comment.
I am confident that NODE_NODE_GRAPH should have simplification disabled. However, it could also make sense to disable simplification for all graph types. If so, we can simply hardcode this as simplify = False
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when there were multiple topics between two nodes, only one of the topics was being displayed. This was caused by graph simplification flag not being passed into the edge-adding code.
Graph simplification was also defaulting to True, when in fact it should be false for the node-to-node graph.
Addresses issue:
#20 - In "Nodes only" mode, multiple topics not shown