Enable button not mandatory anymore #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ree times just in case one message gets lost and added config file for Logitech F710
|
#22 should consider my idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to make this node work with a Logitech F710 I encountered some quirks so I had to look up the sources. I added the possibility of using no enable buttons. In this case the node will continuously sending twist messages. In this case the gamepad has a very stable home position with zeros at all analog sticks. So the stop command is generated naturally by it's home positions after releasing the analog sticks. Also I added a repetition for publishing the stop message. I experienced it a few times that a message got lost especially while using several machines connected by WiFi. So just to be sure the stop message is sent three times. This changes shouldn't have any drawback.