Document bt_navigator error_code_name_prefixes and error_msg #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Wake <[email protected]>
aosmw
force-pushed
the
feature/mw/bt_error_msg_586
branch
from
47c9846
to
61cc31a
Compare
Signed-off-by: Mike Wake <[email protected]>
aosmw
force-pushed
the
feature/mw/bt_error_msg_586
branch
from
795dcae
to
23e4b92
Compare
SteveMacenski
requested changes
Sep 4, 2024
| </Fallback> | ||
| <ClearEntireCostmap name="ClearGlobalCostmap-Context" service_name="global_costmap/clear_entirely_global_costmap"/> | ||
| </RecoveryNode> | ||
| </RateController> | ||
| <RecoveryNode number_of_retries="1" name="RecoveryFollowPath"> | ||
| <FollowPath path="{path}" controller_id="{selected_controller}" error_code_id="{follow_path_error_code}"/> | ||
| <FollowPath path="{path}" controller_id="{selected_controller}" error_code_id="{follow_path_error_code}" error_msg="{follow_path_error_msg}"/> |
There was a problem hiding this comment.
This BT missing the spin/backup error_msg?
There was a problem hiding this comment.
Done, although, spin and backup are not in the default list of error_code_name_prefixes. Do you want them added along with all builtin actions?
std::vector<std::string> error_code_name_prefixes = {
"follow_path",
"compute_path",
};
There was a problem hiding this comment.
I think its fine for them to not be in the defaults, as long as they're in the nav2_params.yaml that we ship by default. I think the absolute-defaults are the follow / compute paths
Signed-off-by: Mike Wake <[email protected]>
aosmw
force-pushed
the
feature/mw/bt_error_msg_586
branch
from
8d20961
to
ed98c63
Compare
Signed-off-by: Steve Macenski <[email protected]>
SteveMacenski
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents featured added to support returning Error codes and messages from failed NavigateToPose/NavigateThroughPoses actions ros-navigation/navigation2#4341