Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused layouts #420

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Conversation

rkent
Copy link

@rkent rkent commented Sep 11, 2024

Just removing some cruft here. As far as I can tell, these layouts are no longer (or were never) used.

It always makes one nervous to remove stuff, but I did search for them (and did not find), plus run them in my full build at index.rosdabbler.com without seeing any issues.

Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs were missed in this cleanup: #258

post can certainly be removed.

The early design of rosindex was to support indexing multiple forks of repositories and consequently packages.

There was some cleanup in #281 removing that extra layer. And I think that with the simpler mandate of only indexing the rosdistros we're down to only needing to have one instance of a repo. There's still an extra drop down and duplicate page created.

image

For example https://index.ros.org/p/mola_viz/ and https://index.ros.org/p/mola_viz/github-MOLAorg-mola/ which are duplicates.

And then there's https://index.ros.org/r/mola/github-MOLAorg-mola/ which has a dropdown of length 1 and only links to itself.
image

I don't see any usages of these either.

@tfoote
Copy link
Member

tfoote commented Sep 15, 2024

Related clean up in #423 while digging through the history

@tfoote tfoote merged commit 0648dd9 into ros-infrastructure:ros2 Sep 15, 2024
1 check passed
@rkent rkent deleted the removed-unused-layouts branch September 15, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants