Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for KEYRING storage of the password of ROSDEP #895

Open
wants to merge 3 commits into
base: cottsay/auth_urls
Choose a base branch
from

Conversation

progtologist
Copy link

I did some initial testing with both python2 and python3 but I cannot vouch 100% about the compatibility of everything. If we can get a publicly accessible authorized rosdep server I can write proper unit tests for everything.

I also took a shot at documenting this!

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2022

Codecov Report

Base: 74.89% // Head: 74.83% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (b119278) compared to base (1153836).
Patch coverage: 61.11% of modified lines in pull request are covered.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           cottsay/auth_urls     #895      +/-   ##
=====================================================
- Coverage              74.89%   74.83%   -0.07%     
=====================================================
  Files                     44       44              
  Lines                   3374     3389      +15     
=====================================================
+ Hits                    2527     2536       +9     
- Misses                   847      853       +6     
Impacted Files Coverage Δ
src/rosdep2/url_utils.py 82.97% <61.11%> (-10.78%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants