Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin cppcheck 1.90. #17

Open
wants to merge 1 commit into
base: latest
Choose a base branch
from

Conversation

nuclearsandwich
Copy link
Contributor

This will install the latest version of cppcheck available from
chocolatey.

Replaces ros2/ci#480's direct revert.

@brawner
Copy link
Collaborator

brawner commented Oct 9, 2020

This looks similar to a draft that @jacobperron showed me trying to debug an issue. It resulted in the error below, hopefully you're not running into the same issue:

https://ci.ros2.org/job/ci_windows/12370/console

@jacobperron
Copy link
Collaborator

jacobperron commented Oct 9, 2020

The error I ran into went away when I pushed my change to this repository (versus trying to run CI against a fork of ros2-cookbooks).

@nuclearsandwich
Copy link
Contributor Author

This looks similar to a draft that @jacobperron showed me trying to debug an issue. It resulted in the error below, hopefully you're not running into the same issue:

Yeah I saw an existing branch but wasn't sure what it's deal was since there was no attached PR.

This will install the latest version of cppcheck available from
chocolatey.

Replaces ros2/ci#480's direct revert.

Signed-off-by: Steven! Ragnarök <[email protected]>
@clalancette clalancette force-pushed the nuclearsandwich/unpin-cppcheck branch from a4c8837 to 4364c57 Compare March 9, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants