Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repos description fetcher to generate pages #4

Merged
merged 14 commits into from
Aug 16, 2024

Conversation

Crola1702
Copy link
Collaborator

@Crola1702 Crola1702 commented Jul 12, 2024

Description

This PR adds fetch_repositories.rb script to fill /content/repos folder with all infra managed repositories.

The script consumes the repositories listed in repos.yml and fetches the information from GitHub API.

@Crola1702 Crola1702 self-assigned this Jul 12, 2024
@Crola1702 Crola1702 changed the title Add repos readme fetch to generate pages Add repos readme fetcher to generate pages Jul 12, 2024
@Crola1702 Crola1702 marked this pull request as ready for review July 12, 2024 19:18
@Crola1702
Copy link
Collaborator Author

@nuclearsandwich this is ready for review

@Crola1702 Crola1702 changed the title Add repos readme fetcher to generate pages Add repos readme description to generate pages Aug 2, 2024
@Crola1702 Crola1702 changed the title Add repos readme description to generate pages Add repos description fetcher to generate pages Aug 2, 2024
The repos stored in the index attributes aren't usable as-is. I ended up
having to pull them out of `@items.find_all` while doing some digging I
discovered that while find_all is a linear time search, it does also
hint the dependency tracking system of nanoc and so it's not that
harmful to use (except in our very large case with the answers archive)

In order to get them to render correctly I also removed the default
layout from the repo item rule.
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up pushing a change directly which is companion to some of these suggestions.

Rules Outdated Show resolved Hide resolved
fetch_repositories.rb Outdated Show resolved Hide resolved
layouts/repo.erb Outdated Show resolved Hide resolved
layouts/repo.erb Outdated Show resolved Hide resolved
layouts/repo.erb Outdated Show resolved Hide resolved
@Crola1702
Copy link
Collaborator Author

@nuclearsandwich, this is ready for re-review

Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits but otherwise good to go!

content/index.md Outdated Show resolved Hide resolved
Rules Outdated Show resolved Hide resolved
content/index.md Outdated Show resolved Hide resolved
@nuclearsandwich nuclearsandwich merged commit 44dbc95 into main Aug 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants