-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add repos description fetcher to generate pages #4
Conversation
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
@nuclearsandwich this is ready for review |
Signed-off-by: Crola1702 <[email protected]>
The repos stored in the index attributes aren't usable as-is. I ended up having to pull them out of `@items.find_all` while doing some digging I discovered that while find_all is a linear time search, it does also hint the dependency tracking system of nanoc and so it's not that harmful to use (except in our very large case with the answers archive) In order to get them to render correctly I also removed the default layout from the repo item rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up pushing a change directly which is companion to some of these suggestions.
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
Signed-off-by: Crola1702 <[email protected]>
@nuclearsandwich, this is ready for re-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nits but otherwise good to go!
Signed-off-by: Crola1702 <[email protected]>
Co-authored-by: Steven! Ragnarök <[email protected]>
Description
This PR adds
fetch_repositories.rb
script to fill/content/repos
folder with all infra managed repositories.The script consumes the repositories listed in
repos.yml
and fetches the information from GitHub API.