-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load the URDF to the resource_manager before parsing it to CM #222
Merged
ahcorde
merged 3 commits into
ros-controls:master
from
saikishor:fix_crash_for_missing_urdf_in_resource_manager
Jan 24, 2024
Merged
Load the URDF to the resource_manager before parsing it to CM #222
ahcorde
merged 3 commits into
ros-controls:master
from
saikishor:fix_crash_for_missing_urdf_in_resource_manager
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ahcorde I believe this will be needed as well. Sorry for the late notice |
saikishor
force-pushed
the
fix_crash_for_missing_urdf_in_resource_manager
branch
from
January 22, 2024 09:42
62cc7bd
to
f71b223
Compare
saikishor
force-pushed
the
fix_crash_for_missing_urdf_in_resource_manager
branch
from
January 22, 2024 09:59
f71b223
to
8612b02
Compare
The binaries seem to be old for this build to work here |
requires #223 |
https://github.com/Mergifyio backport humble iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 5a94805)
mergify bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 5a94805)
This was referenced Jan 24, 2024
ahcorde
pushed a commit
that referenced
this pull request
Jan 24, 2024
…226) Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 5a94805) Co-authored-by: Sai Kishor Kothakota <[email protected]>
ahcorde
pushed a commit
that referenced
this pull request
Jan 24, 2024
…225) Co-authored-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 5a94805) Co-authored-by: Sai Kishor Kothakota <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR similar to ros-controls/gazebo_ros2_control#262