Cleanup controller config #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
|
https://github.com/Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
Signed-off-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 2231745) # Conflicts: # ign_ros2_control_demos/launch/cart_example_effort.launch.py
ahcorde
pushed a commit
that referenced
this pull request
Sep 7, 2023
* Cleanup controller config (#180) Signed-off-by: Alejandro Hernández Cordero <[email protected]> (cherry picked from commit 2231745) Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with this PR in gazebo_ros2_control ros-controls/gazebo_ros2_control#232
The controller config of the velocity and effort controllers (specializations of the forward_command_controller) had some non-existing parameters in the yaml.