Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename cartpole and fix ros2_control yaml in docs #252

Merged
merged 2 commits into from
Jan 1, 2024
Merged

Rename cartpole and fix ros2_control yaml in docs #252

merged 2 commits into from
Jan 1, 2024

Conversation

christophfroehlich
Copy link
Contributor

I found some issues in the docs:

  • the cartpole example is not a cartpole, but only a cart on a rail: I renamed it. A cartpole is waiting for merge with Add an example with a passive joint #172
  • The yaml section included in the docs is wrong/outdated. (there is no type or write_op_modes parameter).
  • joint_state_controller does not exist any more, it's called joint_state_broadcaster now.

@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport iron humble

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 1, 2024 •
edited
Loading

backport iron humble

✅ Backports have been created

@ahcorde ahcorde merged commit b39074a into ros-controls:master Jan 1, 2024
4 of 5 checks passed
mergify bot pushed a commit that referenced this pull request Jan 1, 2024
@christophfroehlich @mergify
Rename cartpole (#252)
3bc9f62 
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit b39074a)
mergify bot pushed a commit that referenced this pull request Jan 1, 2024
@christophfroehlich @mergify
Rename cartpole (#252)
c8c9e2f 
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit b39074a)
This was referenced Jan 1, 2024
Merged
Merged
ahcorde pushed a commit that referenced this pull request Jan 1, 2024
@mergify @christophfroehlich
Rename cartpole (#252) (#253)
cc1b35e 
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit b39074a)

Co-authored-by: Christoph Fröhlich <[email protected]>
ahcorde pushed a commit that referenced this pull request Jan 1, 2024
@mergify @christophfroehlich
Rename cartpole (#252) (#254)
e5b5b7c 
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit b39074a)

Co-authored-by: Christoph Fröhlich <[email protected]>
@christophfroehlich christophfroehlich deleted the fix_docs branch January 1, 2024 20:46
@ahcorde ahcorde mentioned this pull request Jan 3, 2024
Merged
k-takeshita pushed a commit to hsr-project/gazebo_ros2_control that referenced this pull request Oct 21, 2024
@mergify @christophfroehlich @keisuketakeshita
Rename cartpole (ros-controls#252) (ros-controls#254)
8af76ec 
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit b39074a)

Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophfroehlich @ahcorde