Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate CI for humble #223

Merged

Conversation

christophfroehlich
Copy link
Contributor

CI is not activated for branches other than master:

Gazebo ros2 control CI

I don't think this is on purpose?

@ahcorde
Copy link
Collaborator

ahcorde commented Aug 14, 2023

we have different branches for each one of the ROS version, this might fail because of the different ros_control APIs

@christophfroehlich
Copy link
Contributor Author

I'm aware of the branches, but the workflow file in the humble branch doesn't run on pushs on humble:

maybe the workflow file doesn't have to be updated on the master branch, but it works if they get updated on both as far as I know.

@christophfroehlich
Copy link
Contributor Author

I made this PR because humble has no status in the table of the readme
image

@destogl destogl self-requested a review September 25, 2023 17:46
@destogl destogl merged commit 12dad63 into ros-controls:master Sep 25, 2023
5 checks passed
@christophfroehlich christophfroehlich deleted the christophfroehlich-patch-1 branch September 25, 2023 19:05
@christophfroehlich
Copy link
Contributor Author

apparently, it still doesn't work with the change on the master branch. Can we try a backport of this change to humble?

@ahcorde
Copy link
Collaborator

ahcorde commented Oct 4, 2023

https://github.com/Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2023

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 4, 2023
(cherry picked from commit 12dad63)
ahcorde pushed a commit that referenced this pull request Oct 4, 2023
(cherry picked from commit 12dad63)

Co-authored-by: Christoph Fröhlich <[email protected]>
@christophfroehlich
Copy link
Contributor Author

now it's green, thanks ;)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants