Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the C++ version to 17 #221

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Set the C++ version to 17 #221

merged 4 commits into from
Aug 15, 2023

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Aug 14, 2023

We should backport this to humble and iron

@ahcorde
Set the C++ version to 17
2e4b137 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde ahcorde self-assigned this Aug 14, 2023
@ahcorde
examples packages too
b279de8 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
christophfroehlich
christophfroehlich approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as it is standard since galactic acc to REP-2000

@ahcorde ahcorde enabled auto-merge (squash) August 14, 2023 10:58
@bmagyar
Copy link
Member

bmagyar commented Aug 14, 2023

Just got a buildfarm fail email. Related to this?

@ahcorde
Copy link
Collaborator Author

ahcorde commented Aug 14, 2023

buildfarm should email you only with merged PRs, isn't it?

@ahcorde ahcorde disabled auto-merge August 15, 2023 17:25
@ahcorde ahcorde merged commit 6da415c into master Aug 15, 2023
5 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/cpp17 branch August 15, 2023 17:26
@ahcorde
Copy link
Collaborator Author

ahcorde commented Aug 15, 2023

https://github.com/Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Aug 15, 2023 •
edited
Loading

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 15, 2023
@ahcorde @mergify
Set the C++ version to 17 (#221)
25d8522 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit 6da415c)
@mergify mergify bot mentioned this pull request Aug 15, 2023
Merged
ahcorde added a commit that referenced this pull request Aug 15, 2023
@mergify @ahcorde
Set the C++ version to 17 (#221) (#228)
5efa480 
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
(cherry picked from commit 6da415c)

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophfroehlich christophfroehlich christophfroehlich approved these changes

@destogl destogl Awaiting requested review from destogl

@bmagyar bmagyar Awaiting requested review from bmagyar

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @bmagyar @christophfroehlich