Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for passive joints - joints with only state interfaces #153

Conversation

destogl
Copy link
Member

@destogl destogl commented Oct 2, 2022

The PR if functional but the code is not tested against all use cases, especially those with mimic joints.
I don't think there are any issues, but this changes has to be extensivelly tested before merging.

@destogl destogl added enhancement New feature or request help wanted Extra attention is needed labels Oct 2, 2022
@destogl destogl self-assigned this Oct 2, 2022
@christophfroehlich
Copy link
Contributor

I tested this successfully with the basic examples in this repo, but what is the goal of this change @destogl? Passive joints with state interfaces only worked already before?

@destogl
Copy link
Member Author

destogl commented Jan 5, 2023

I tested this successfully with the basic examples in this repo, but what is the goal of this change @destogl? Passive joints with state interfaces only worked already before?

This PR separates commanding and state joints. The issue I was having was crashing of plugin when joint didn't have command interfaces, but only state interfaces. But you said this was working… Have to test this again then. I was using Gazebo Sim later for the project, so I am not sure anymore what the exact details behind it.

@destogl destogl force-pushed the supprot-for-passive-joints-with-state-interfaces branch from 7c23285 to e6c2afe Compare January 5, 2023 19:32
@christophfroehlich
Copy link
Contributor

See #172 : This is the way I used it since foxy up to now.. Never had problems with that.

@destogl destogl closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants