Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.2.0 on CRAN #338

Merged
merged 2 commits into from
Jan 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Type: Package
Package: qualtRics
Title: Download 'Qualtrics' Survey Data
Version: 3.1.7.9000
Version: 3.2.0
Authors@R: c(
person("Jasper", "Ginn", , "[email protected]", role = "aut"),
person("Jackson", "Curtis", , "[email protected]", role = "ctb"),
Expand Down Expand Up @@ -53,5 +53,5 @@ VignetteBuilder:
Encoding: UTF-8
LazyData: FALSE
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.2.3
RoxygenNote: 7.3.1
Config/testthat/edition: 3
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# qualtRics (development version, to be released as 3.2.0)
# qualtRics 3.2.0

- Changed how multiple choice questions are mapped to an R factor with the `convert` argument to `fetch_survey()`, to now excluding `NA` as a factor level (#315)

Expand Down
2 changes: 1 addition & 1 deletion R/fetch_survey.R
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@
# Check/format arguments --------------------------------------------------

if (lifecycle::is_present(last_response)) {
lifecycle::deprecate_warn("3.1.2", "fetch_survey(last_response = )")
lifecycle::deprecate_stop("3.1.2", "fetch_survey(last_response = )")

Check warning on line 223 in R/fetch_survey.R

View check run for this annotation

Codecov / codecov/patch

R/fetch_survey.R#L223

Added line #L223 was not covered by tests
}
if (lifecycle::is_present(force_request)) {
lifecycle::deprecate_warn("3.2.0", "fetch_survey(force_request = )")
Expand Down
2 changes: 1 addition & 1 deletion README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ knitr::opts_chunk$set(
[Joseph O'Brien]([email protected]),
[Jasper Ginn](https://jasperhg90.github.io/)<br/>
**License:**
[MIT](https://opensource.org/licenses/MIT)
[MIT](https://opensource.org/license/mit/)

<!-- badges: start -->
[![R-CMD-check](https://github.com/ropensci/qualtRics/workflows/R-CMD-check/badge.svg)](https://github.com/ropensci/qualtRics/actions)
Expand Down
16 changes: 8 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
**Authors:** [Julia Silge](https://juliasilge.com/), [Joseph
O’Brien]([email protected]), [Jasper
Ginn](https://jasperhg90.github.io/)<br/> **License:**
[MIT](https://opensource.org/licenses/MIT)
[MIT](https://opensource.org/license/mit/)

<!-- badges: start -->

Expand Down Expand Up @@ -137,13 +137,13 @@ dates or for specific survey items, and more.

## Related work

- [Jason Bryer](https://github.com/jbryer/qualtrics) wrote an R package
to work with the previous version of the Qualtrics API
- [QualtricsTools](https://github.com/emma-morgan/QualtricsTools)
creates automatic reports in shiny.
- [qsurvey](https://github.com/jamesdunham/qsurvey) by James Dunham
focuses on testing and review of surveys before fielding, and analysis
of responses afterward.
- [Jason Bryer](https://github.com/jbryer/qualtrics) wrote an R
package to work with the previous version of the Qualtrics API
- [QualtricsTools](https://github.com/emma-morgan/QualtricsTools)
creates automatic reports in shiny.
- [qsurvey](https://github.com/jamesdunham/qsurvey) by James Dunham
focuses on testing and review of surveys before fielding, and
analysis of responses afterward.

### Community Guidelines

Expand Down
6 changes: 1 addition & 5 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
## Release summary

This is the 14th CRAN release of qualtRics (the 8th since it has returned to CRAN after being archived). This release makes a change necessary to work with the latest version of [vcr](https://cran.r-project.org/package=vcr) (for automated testing), as well as some bug fixes and refactoring code for checking arguments.

## R CMD check results

0 errors | 0 warnings | 0 note
This is the 15th CRAN release of qualtRics (the 9th since it has returned to CRAN after being archived). This release corrects a prevous `.Rd` argument problem, as well as adding new functionality around where survey results are stored on disk.
14 changes: 8 additions & 6 deletions tests/testthat/_snaps/fetch-survey.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,21 @@

Code
fetch_survey("1234", force_request = TRUE)
Warning <lifecycle_warning_deprecated>
Condition
Warning:
The `force_request` argument of `fetch_survey()` is deprecated as of qualtRics 3.2.0.
Error <rlang_error>
Qualtrics API reported a not found error (404):
Error in `qualtrics_response_codes()`:
! Qualtrics API reported a not found error (404):
* Please check if you are using the correct survey ID.

---

Code
fetch_survey("1234", save_dir = "~/Desktop")
Warning <lifecycle_warning_deprecated>
Condition
Warning:
The `save_dir` argument of `fetch_survey()` is deprecated as of qualtRics 3.2.0.
Error <rlang_error>
Qualtrics API reported a not found error (404):
Error in `qualtrics_response_codes()`:
! Qualtrics API reported a not found error (404):
* Please check if you are using the correct survey ID.

Loading