New MECALL backend #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
thejpster
reviewed
Sep 8, 2024
riscv-slic/src/api.rs
Outdated
| @@ -79,6 +81,20 @@ pub unsafe fn set_priority<I: crate::InterruptNumber>(interrupt: I, priority: u8 | |||
| } | |||
|
|
|||
| /// Stabilized API for pending a software interrupt on the SLIC. | |||
| /// | |||
There was a problem hiding this comment.
Sounds like this should be an unsafe function, because of all the human-checked prerequisites.
There was a problem hiding this comment.
I updated the mecall-backend export code so it now makes sure that the mepc register is not neglected. In this way, users can now call pend safely outside and inside interrupt handlers.
romancardenas
force-pushed
the
mecall
branch
from
3875ed5
to
3bb7af7
Compare
|
I think the mecall version should be built in CI. I'd like to see an RP235x example too and I'll try and look at that when I have time. |
|
Will do! I have bought a couple of RP Pico 2 boards, so I will also do some on-board tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backend triggers
MachineEnvCallexceptions to obtain the desired behavior.The
examples/ecall.rsworks following this approach. I still want to make sure that there are no soundness issues before merging this PR. I also use the new approach I'm developing for the RISC-V ecosystem, so it is better to wait until all these changes are published to crates.io.If this approach works, then any RISC-V target will be compatible with
riscv-slic, regardless of having CLINT or another software interrupt peripheral 😁