Possibility to use service as person_fn rather than a static function

[zinkovskiy]

Description of the change

This PR allow to use service as person_fn

I created PersonProvider service that is used by default

To use custom person provider you need to define your own service with alias rollbar.person-provider in services.yml of your application, for example:

  rollbar.person-provider:
    class: App\Service\Rollbar\Provider\PersonProvider

No need to define person_fn option (thx to DI), the service will be used automatically, but if person_fn is defined, then it will be used

Logic of obtaining user info is not changed.

I've also discovered, that security.token_storage and serializer are private and cannot be obtained from container, so I passed it to Rollbar\Symfony\RollbarBundle\Factories\RollbarHandlerFactory constructor

Type of change

• Bug fix (non-breaking change that fixes an issue)

Related issues

• Fix Possibility to use service as person_fn rather than a static function #52

Checklists

Development

• All tests related to the changed code pass in development

Code review

I tested these changes on symfony 5.4 and symfony 6.4, it works well

@danielmorell could you please take a look on it?

[zdavis-rollbar]

@zinkovskiy, we are looking for a maintainer or owner of the repo. Would you like to participate?

[zinkovskiy]

@zinkovskiy, we are looking for a maintainer or owner of the repo. Would you like to participate?

Hi @zdavis-rollbar yes, I'm ready to maintain. contact me anytime when you have time, we are interested in keeping the project up to date

[waltjones]

@zinkovskiy Thank you for the PR. Please add tests for the new functionality, and run tests locally to ensure CI will pass.

[zinkovskiy]

@zinkovskiy Thank you for the PR. Please add tests for the new functionality, and run tests locally to ensure CI will pass.

Hi @waltjones, yes, I missed it. Now it's added
Hope it helps to accept changes 🙂

[danielmorell]

Hey Anton, thank you for your work on this and your patience in getting this reviewed!

I appreicate how customizable and extensible you have made this. Great work!