Move user provided extra data under custom #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arpad Fulop <[email protected]>
custom is a better place for this data, since that's filled by the user and not by the SDK. However, some SDK generated fields that are also filled through extra_data (in the logger) should not be moved. Signed-off-by: Arpad Fulop <[email protected]>
|
This pull request has been linked to Shortcut Story #127161: Release new beta version of pyrollbar that puts extra_data under custom. |
Signed-off-by: Arpad Fulop <[email protected]>
|
Merged main branch to pick up CI changes. |
waltjones
approved these changes
Jun 26, 2023
arpad-fulop-rb
added a commit
that referenced
this pull request
Aug 8, 2023
This reverts commit e3e1595, Except for the version tag. We decided we won't need these changes. Signed-off-by: Arpad Fulop <[email protected]>
arpad-fulop-rb
added a commit
that referenced
this pull request
Aug 8, 2023
…xtra-data-handling Revert "Move user provided extra data under custom (#431)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
customis a better place for user providedextra_data, sincecustomis where users can put data interesting to them. However,customis not to be filled by the SDK, so some SDK generated fields that are also filled usingextra_data(inlogger.py) should not be moved undercustom.Type of change
Related issues
Checklists
Development
Code review