Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to be able to set a device as the current active device via the Device tree view. Also added command to clear the active device. #597

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

spoyser
Copy link
Contributor

@spoyser spoyser commented Sep 28, 2024

Add feature to be able to set a device as the current active device via the Device tree view.
Also added command to clear the active device.

…ia the Deive tree view.

Also added command to clear the active device.
@spoyser
Copy link
Contributor Author

spoyser commented Sep 28, 2024

I added the ClearActiveDevice command for a common use case (for me anyway) where the device you want to control is not showing in the tree view (e.g. not in developer mode).
By clearing the active device, next time it is needed VSCode will prompt you for it, assuming you have "brightscript.remoteControl.host":"${promptForHost}" in your VSCode settings.

Copy link
Member

@TwitchBronBron TwitchBronBron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thank you for keeping it so focused. The PR was easy to review, and I think the feature works well. Nice work!

@TwitchBronBron TwitchBronBron merged commit 923a317 into rokucommunity:master Oct 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants