Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes arbitrary limits from eqValues & eqArray #303

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions framework/src/source/CommonUtils.bs
Original file line number Diff line number Diff line change
Expand Up @@ -645,11 +645,6 @@ namespace rooibos.common
' * @returns {boolean} - True if values are equal or False in other case.
' */
function eqValues(Value1, Value2, fuzzy = false, callCount = 0) as dynamic
if callCount > 10
? "REACHED MAX ITERATIONS DOING COMPARISON"
return true
end if

' Workaraund for bug with string boxing, and box everything else
val1Type = rooibos.common.getSafeType(Value1)
val2Type = rooibos.common.getSafeType(Value2)
Expand Down Expand Up @@ -769,10 +764,6 @@ namespace rooibos.common
' * @returns {boolean} - True if arrays are equal or False in other case.
' */
function eqArray(Value1, Value2, fuzzy = false, callCount = 0) as dynamic
if callCount > 30
? "REACHED MAX ITERATIONS DOING COMPARISON"
return true
end if
if not (rooibos.common.isArray(Value1)) or not rooibos.common.isArray(Value2)
return false
end if
Expand Down