Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: dynamic job names #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

benv666
Copy link

@benv666 benv666 commented May 24, 2023

I've added two variables, for the eth2 and validator job selectors.
This allows users such as me that already run external monitoring to easily adapt the dashboard to their setup.
(in my instance I have a central prometheus that scrapes several items on my node, by changing the job name I can make the dashboard functional without having to jump through hoops)

These variables will be prompted and can be changed during import:
image

Feedback welcome.

@jclapis
Copy link
Member

jclapis commented Jun 19, 2023

Can you put the old v1.3.0 dashboard file back in instead of removing it post-rename? I can approve this for the next dashboard but don't want to clobber the current v1.3.0 source.

@benv666 benv666 closed this Jun 21, 2023
@benv666 benv666 force-pushed the master branch 2 times, most recently from 79f714a to fd3da60 Compare June 21, 2023 08:31
@benv666
Copy link
Author

benv666 commented Jun 21, 2023

Accidental close there, I've reverted the 1.3.0 file and added 1.3.1 with a third variable to also make the eth1 job name dynamic.
While this works for the eth1 job, I did note there's a hardcoded geth in a few spots - not sure if that's by design since I'm not running it like that.

@benv666 benv666 reopened this Jun 21, 2023
@jclapis
Copy link
Member

jclapis commented Jun 27, 2023

Accidental close there, I've reverted the 1.3.0 file and added 1.3.1 with a third variable to also make the eth1 job name dynamic. While this works for the eth1 job, I did note there's a hardcoded geth in a few spots - not sure if that's by design since I'm not running it like that.

It is by design because Geth has a different metrics path than Besu and Nethermind; due to that, geth is for Geth, eth1 is for Besu and Nethermind. I couldn't find a way to have one Prometheus job scrape multiple endpoints, so we'd have to make it an envsubst variable. Unfortunately, that requires knowing which EC is selected at all times (and the Smartnode doesn't know what's selected for hybrid mode).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants