Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow joystick disconnection and reconnection instead of going into exception #14

Open
wants to merge 3 commits into
base: GenericRawToTwist
Choose a base branch
from

Conversation

0Nel
Copy link

@0Nel 0Nel commented Apr 18, 2023

This code is functional and has been tested in the field. I expect that the following two points should be addressed before merging. However, before putting more effort into it, I wanted to open this MR to gather some feedback.

  • replace the raw pointer with unique pointer
  • make this behaviour optional (e.g. property allow_disconnect) and set it to false by default to not break anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant