Tolerant Block Parsing #7112
Draft
Tolerant Block Parsing #7112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -317,6 +317,7 @@ pub fn desugar_expr<'a>( | |||
| | AccessorFunction(_) | |||
| | Var { .. } | |||
| | Underscore { .. } | |||
| | EmptyBlock(_) | |||
There was a problem hiding this comment.
Slight preference to calling this MalformedEmptyBlock, to make it extra clear
| @@ -539,6 +541,15 @@ pub enum Expr<'a> { | |||
| OptionalFieldInRecordBuilder(&'a Loc<&'a str>, &'a Loc<Expr<'a>>), | |||
| } | |||
|
|
|||
| #[derive(Clone, Copy, Debug, PartialEq, Eq)] | |||
| pub enum EmptyBlockParent { | |||
There was a problem hiding this comment.
Shouldn't this information be derivable from where the empty block exists in the syntax tree?
| ), | ||
| map_with_arena( | ||
| space0_after_e( | ||
| optional(space0_after_e( | ||
| block(options, false, EIf::IndentThenBranch, EIf::ThenBranch), |
There was a problem hiding this comment.
What if we just made the block function return in malformed empty block?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR plans to convert empty blocks into malformed blocks and add malformed expressions to the end of blocks not already ending in expressions. In doing so, we can make the user experience better for Roc devs by more consistently continuing to parse and analyze incorrect code.
An example error:
The PR is only partially done, but I figured I'd release a draft to get eyes on the overall plan.