Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade llvm 18 zig 13 #6921
base: main
Are you sure you want to change the base?
Upgrade llvm 18 zig 13 #6921
Changes from all commits
01b3adf
a42d105
d50317d
5d4f820
011c13f
a8dd624
2ba17a7
a5d9966
697bdb9
2be2c02
1642438
6278c4d
41192b7
c082025
c47915a
5f95b59
67d7f0a
4c9610b
a589d7d
4f10552
96db1bd
f3b5498
fb62425
d6c6783
5c1e6d4
e772348
a2fb247
2c05760
5b68add
8090e99
1519e5f
74ca0b0
8823ddd
93b7056
cfbcfd1
f176bea
a4259e8
af7015f
b4ec321
53a1edb
f28ddea
12e8710
1750e8b
16a5ed9
0c184fb
57b277d
0a813be
7ab1514
210397a
8813a09
99e2bc2
0c79ccd
530cffa
4750dac
60eb6e5
915097d
eb6d61b
dc3aa06
f445172
f830447
a432bb8
dc3369b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to confirm this location when we install LLVM 18 on the Windows CI machine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a new release for Windows LLVM in https://github.com/roc-lang/llvm-package-windows/releases/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirm this location is correct when we update the Windows CI machines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update with new release of roc-lang Windows LLVM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the transition it is helpful to keep both the old and new cache locations ignored so users switching between these branches are less affected.