less colors and more contrast in terminal #6525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anton-4
commented
Feb 14, 2024
Comment on lines
+261
to
+264
| red: "\u{001b}[1;31m", | ||
| green: "\u{001b}[1;32m", | ||
| yellow: "\u{001b}[1;33m", | ||
| cyan: "\u{001b}[1;36m", |
There was a problem hiding this comment.
1; to use the increased visibility variants.
Anton-4
commented
Feb 17, 2024
Comment on lines
-544
to
+545
| let (failed, passed) = roc_repl_expect::run::run_toplevel_expects( | ||
| let (failed_count, passed_count) = roc_repl_expect::run::run_toplevel_expects( |
There was a problem hiding this comment.
More self-evident names
Anton-4
commented
Feb 17, 2024
| println!( | ||
| "\x1B[{}m{}\x1B[39m {} and \x1B[{}m{}\x1B[39m {} found in {} ms.", | ||
| if problems.errors == 0 { | ||
| 32 // green | ||
| } else { | ||
| 33 // yellow | ||
| }, | ||
| problems.errors, | ||
| if problems.errors == 1 { | ||
| "error" | ||
| } else { | ||
| "errors" | ||
| }, | ||
| if problems.warnings == 0 { | ||
| 32 // green | ||
| } else { | ||
| 33 // yellow | ||
| }, | ||
| problems.warnings, | ||
| if problems.warnings == 1 { | ||
| "warning" | ||
| } else { | ||
| "warnings" | ||
| }, | ||
| total_time.as_millis(), | ||
| ); | ||
|
|
||
| problems.print_to_stdout(total_time); |
There was a problem hiding this comment.
This code was duplicated in print_to_stdout.
Anton-4
commented
Feb 17, 2024
Comment on lines
-101
to
-116
| pub fn strip_colors(str: &str) -> String { | ||
| use roc_reporting::report::ANSI_STYLE_CODES; | ||
|
|
||
| str.replace(ANSI_STYLE_CODES.red, "") | ||
| .replace(ANSI_STYLE_CODES.green, "") | ||
| .replace(ANSI_STYLE_CODES.yellow, "") | ||
| .replace(ANSI_STYLE_CODES.blue, "") | ||
| .replace(ANSI_STYLE_CODES.magenta, "") | ||
| .replace(ANSI_STYLE_CODES.cyan, "") | ||
| .replace(ANSI_STYLE_CODES.white, "") | ||
| .replace(ANSI_STYLE_CODES.bold, "") | ||
| .replace(ANSI_STYLE_CODES.underline, "") | ||
| .replace(ANSI_STYLE_CODES.reset, "") | ||
| .replace(ANSI_STYLE_CODES.color_reset, "") | ||
| } | ||
|
|
|
Very cool! Two thoughts:
|
This is what is looks like on Windows. Looks good to me. ❤️
p.s. I'm not sure what is going on with that debug statement in rustyline... |
|
Thanks for checking that @lukewilliamboswell :) @rtfeldman I've changed the color of the underline to match roc repl. |
rtfeldman
approved these changes
Feb 20, 2024
|
Great stuff, thanks for improving this @Anton-4! 😍 |
Anton-4
added a commit
that referenced
this pull request
Feb 21, 2024
Anton-4
added a commit
that referenced
this pull request
Feb 23, 2024
update repl_basic_test because of #6525
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked how our terminal colors looked on macos. ubuntu, nixOS and raspberryOS. The colors we internally call blue and magenta regularly did not meet the AA wcag standard so I removed them and used other colors instead. I also changed the colors we still use to their "improved visibility variants". Other popular languages and command line tools often use these variants as well.
after (left) and before (right) on raspberryOS:
Closes #6512