Remove Nat
#6422
Merged
Remove Nat
#6422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtfeldman
force-pushed
the
remove-nat
branch
3 times, most recently
from
1e775a3
to
328a9eb
Compare
rtfeldman
force-pushed
the
list-without-nat
branch
from
cbfc92f
to
442f095
Compare
The bug reproduces if you go to the commit before this one; seems to be the problem is importing an un-exposed value as unqualified (possibly from a package, might be relevant)
rtfeldman
force-pushed
the
remove-nat
branch
from
d9aded6
to
e8a0b09
Compare
This reverts commit e8a0b09.
The usize one gets used internally for things like pattern matches. This is both more efficient (means they don't have to do unnecessary casts) and also less error-prone due to e.g. comparing length to capacity, which is usize.
rtfeldman
force-pushed
the
remove-nat
branch
from
78dfdf4
to
1568888
Compare
Seamless slices make this obsolete!
This reverts commit ad1bca4.
rtfeldman
force-pushed
the
remove-nat
branch
from
1568888
to
12aa775
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now everything in public APIs that was
NatisU64instead.(In-memory data structures are the same as before; we cast to/from
usizebehind the scenes.)This also removes some builtin functions:
Str.fromUtf8Rangebecause seamless slices make it unnecessary (can now doList.sublistfollowed byStr.fromUtf8to get the same functionality).Num.bytesToU16and friends - now that we have seamless slices, these shouldn't be part of builtins anymore. Explicit endianness is needed, at which point these can be done in userspace just fine.