Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small str const #6246

Closed
wants to merge 2 commits into from
Closed

Small str const #6246

wants to merge 2 commits into from

Conversation

folkertdev
Copy link
Contributor

sadly does not work because it runs into #3609. @bhansconnect what is the status of that. did the recent zig upgrade change this at all?

@bhansconnect
Copy link
Contributor

bhansconnect commented Dec 11, 2023

I haven't touched #3609 in a long time. Last time I tried, I got a partial solution but due to all of the extra data shifting, it was brittle and generally just led to segfaults. The biggest part of the problem is that the roc app needs to add an arbitrary number of entries to the dynamic table. 1 for each absolute relocation. My original attempt just led to way to many extra shifts and became a mess.

What I need to test as a next step is just moving the entire dynamic table to the end of the executable during preprocessing. That way, during surgical linking there would be no need to shift the entire host part of the application again. Then the surgical linker would just first append to the dynamic table then append all of the extra application stuff.

@bhansconnect
Copy link
Contributor

Wrote up a more concrete reply here: #3609 (comment)

Copy link

Thank you for your contribution! Sometimes PRs end up staying open for a long time without activity, which can make the list of open PRs get long and time-consuming to review. To keep things manageable for reviewers, this bot automatically closes PRs that haven’t had activity in 60 days. This PR hasn’t had activity in 30 days, so it will be automatically closed if there is no more activity in the next 30 days. Keep in mind that PRs marked Closed are not deleted, so no matter what, the PR will still be right here in the repo. You can always access it and reopen it anytime you like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants