Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report lacking to while parsing app header #6105

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Report lacking to while parsing app header #6105

merged 5 commits into from
Nov 28, 2023

Conversation

caryoscelus
Copy link
Contributor

No description provided.

@Anton-4
Copy link
Collaborator

Anton-4 commented Nov 27, 2023

Thanks for helping out @caryoscelus! Could you add a test for this as well?

@caryoscelus
Copy link
Contributor Author

@Anton-4 sure! it seems there's also a lot of space to lower code repetition while i'm at it

@caryoscelus
Copy link
Contributor Author

there's also a lot of space to lower code repetition while i'm at it

on second thought, probably condensing code isn't worth here

@Anton-4 ready for review

Anton-4
Anton-4 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@Anton-4 Anton-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @caryoscelus!

@Anton-4 Anton-4 merged commit 10897ab into roc-lang:main Nov 28, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anton-4 Anton-4 Anton-4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caryoscelus @Anton-4