-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --output flag #5920
Merged
Merged
Add --output flag #5920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtfeldman
force-pushed
the
output-flag
branch
from
October 20, 2023 00:46
eed249f
to
eebec8a
Compare
rtfeldman
force-pushed
the
output-flag
branch
from
October 20, 2023 02:07
79413d8
to
a5980e2
Compare
rtfeldman
force-pushed
the
output-flag
branch
from
October 20, 2023 02:50
a5980e2
to
7b83dd6
Compare
rtfeldman
force-pushed
the
output-flag
branch
from
October 22, 2023 19:05
cc0bb46
to
babeacc
Compare
Anton-4
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds it to both
roc build
androc docs
.Also changes it so that the default output (if you don't pass
--output
explicitly) is the path of your input.roc
file but with the file extension changed. So now the string afterapp
in app modules is ignored, and in the future it'll be removed.