Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force reqwest version #5882

Merged
merged 1 commit into from
Oct 3, 2023
Merged

force reqwest version #5882

merged 1 commit into from
Oct 3, 2023

Conversation

Anton-4
Copy link
Collaborator

@Anton-4 Anton-4 commented Oct 3, 2023

This fixes the the breaking tests before building nightlies on macos, due to a bug in the latest releases of reqwest.

 The roc command:

  "/Users/m1ci/actions-runner2/_work/roc/roc/target/release/roc --max-threads=1 /Users/m1ci/actions-runner2/_work/roc/roc/examples/cli/ingested-file.roc --"

had unexpected stderr:

  🔨 Rebuilding platform...
Undefined symbols for architecture arm64:
  "_SCDynamicStoreCopyProxies", referenced from:
      __ZN20system_configuration13dynamic_store14SCDynamicStore11get_proxies17h9364091d51e512b0E in macos-arm64.o
  "_SCDynamicStoreCreateWithOptions", referenced from:
      __ZN20system_configuration13dynamic_store14SCDynamicStore6create17ha461b4b2450916f0E in macos-arm64.o
  "_kSCDynamicStoreUseSessionKeys", referenced from:
      __ZN20system_configuration13dynamic_store30SCDynamicStoreBuilder$LT$T$GT$20create_store_options17h502ae73ba7f0a696E in macos-arm64.o
  "_kSCPropNetProxiesHTTPEnable", referenced from:
      __ZN7reqwest5proxy22get_from_platform_impl17h37558a23f1abce25E in macos-arm64.o
  "_kSCPropNetProxiesHTTPPort", referenced from:
      __ZN7reqwest5proxy22get_from_platform_impl17h37558a23f1abce25E in macos-arm64.o
  "_kSCPropNetProxiesHTTPProxy", referenced from:
      __ZN7reqwest5proxy22get_from_platform_impl17h37558a23f1abce25E in macos-arm64.o
  "_kSCPropNetProxiesHTTPSEnable", referenced from:
      __ZN7reqwest5proxy22get_from_platform_impl17h37558a23f1abce25E in macos-arm64.o
  "_kSCPropNetProxiesHTTPSPort", referenced from:
      __ZN7reqwest5proxy22get_from_platform_impl17h37558a23f1abce25E in macos-arm64.o
  "_kSCPropNetProxiesHTTPSProxy", referenced from:
      __ZN7reqwest5proxy22get_from_platform_impl17h37558a23f1abce25E in macos-arm64.o
ld: symbol(s) not found for architecture arm64
/Users/m1ci/actions-runner2/_work/roc/roc/examples/cli/ingested-file: No such file or directory
thread 'main' panicked at 'not yet implemented: gracefully handle `ld` (or `zig` in the case of wasm with --optimize) returning exit code Some(1)', crates/compiler/build/src/program.rs:1049:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

The roc command:

  "/Users/username1/actions-runner/_work/roc/roc/target/release/roc --max-threads=1 /Users/username1/actions-runner/_work/roc/roc/examples/helloWorldNoURL.roc --"

had unexpected stderr:

  🔨 Rebuilding platform...
Undefined symbols for architecture x86_64:
  "_SCDynamicStoreCopyProxies", referenced from:
      __ZN20system_configuration13dynamic_store14SCDynamicStore11get_proxies17haf6647afa069c62cE in macos-x64.o
  "_SCDynamicStoreCreateWithOptions", referenced from:
      __ZN20system_configuration13dynamic_store14SCDynamicStore6create17h3410712259de6324E in macos-x64.o
  "_kSCDynamicStoreUseSessionKeys", referenced from:
      __ZN20system_configuration13dynamic_store30SCDynamicStoreBuilder$LT$T$GT$20create_store_options17hb356ed04d634f084E in macos-x64.o
  "_kSCPropNetProxiesHTTPEnable", referenced from:
      __ZN7reqwest5proxy22get_from_platform_impl17hc14c4d9c33c0f4dcE in macos-x64.o
  "_kSCPropNetProxiesHTTPPort", referenced from:
      __ZN7reqwest5proxy22get_from_platform_impl17hc14c4d9c33c0f4dcE in macos-x64.o
  "_kSCPropNetProxiesHTTPProxy", referenced from:
      __ZN7reqwest5proxy22get_from_platform_impl17hc14c4d9c33c0f4dcE in macos-x64.o
  "_kSCPropNetProxiesHTTPSEnable", referenced from:
      __ZN7reqwest5proxy22get_from_platform_impl17hc14c4d9c33c0f4dcE in macos-x64.o
  "_kSCPropNetProxiesHTTPSPort", referenced from:
      __ZN7reqwest5proxy22get_from_platform_impl17hc14c4d9c33c0f4dcE in macos-x64.o
  "_kSCPropNetProxiesHTTPSProxy", referenced from:
      __ZN7reqwest5proxy22get_from_platform_impl17hc14c4d9c33c0f4dcE in macos-x64.o
ld: symbol(s) not found for architecture x86_64
thread 'main' panicked at 'not yet implemented: gracefully handle `ld` (or `zig` in the case of wasm with --optimize) returning exit code Some(1)', crates/compiler/build/src/program.rs:1049:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@Anton-4
force reqwest version
4c93bf9 
This fixes the  ... breaking tests before building nightlies on macos.
Anton-4
Anton-4 commented Oct 3, 2023
View reviewed changes
Cargo.toml
@@ -137,7 +137,7 @@ quote = "1.0.23"
rand = "0.8.5"
regex = "1.7.1"
remove_dir_all = "0.8.1"
reqwest = { version = "0.11.14", default-features = false, features = ["blocking", "rustls-tls"] } # default-features=false removes libopenssl as a dependency on Linux, which might not be available!
reqwest = { version = "0.11.20", default-features = false, features = ["blocking", "rustls-tls"] } # default-features=false removes libopenssl as a dependency on Linux, which might not be available!
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple update

Anton-4
Anton-4 commented Oct 3, 2023
View reviewed changes
examples/cli/cli-platform/Cargo.toml
@@ -19,7 +19,7 @@ path = "src/main.rs"
[dependencies]
backtrace = "0.3"
libc = "0.2"
reqwest = { version = "0.11.11", default-features = false, features = ["blocking", "rustls-tls"] }
reqwest = { version = "=0.11.20", default-features = false, features = ["blocking", "rustls-tls"] }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With = we force the exact version.

@Anton-4 Anton-4 enabled auto-merge October 3, 2023 15:28
@Anton-4 Anton-4 mentioned this pull request Oct 3, 2023
Merged
@Anton-4
Copy link
Collaborator Author

Anton-4 commented Oct 3, 2023

Thanks Folkert :)

@Anton-4 Anton-4 merged commit b00f25b into main Oct 3, 2023
14 checks passed
@Anton-4 Anton-4 deleted the reqwest_cli_fix branch October 3, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@folkertdev folkertdev folkertdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anton-4 @folkertdev