Allow rust binaries to remove dead code #5855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: we may need to add a special init function to stop linker based dead code elimination. That or special linker commands to keep `roc_*` functions. Currently this is working on my x86 machine without it though. Guide here if needed on the init function: https://stackoverflow.com/questions/43712979/how-to-export-a-symbol-from-a-rust-executable
|
Given test's pass on all platforms, this change should be safe and work across systems. There is still a small chance that a complex enough platform could hit an issue, but i think that is unlikely given the cli example platform is working on all of these systems. |
Anton-4
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple solution seems to just work, I am a bit surprised, I swear that I tried it before and hit linker issues. Anyway, if we update the basic-cli platform it drops from about 100MB to about 15MB.
Note: we may need to add a special init function to stop linker based dead code elimination. That or special linker commands to keep
roc_*functions. Currently this is working on my x86 machine without it though.Guide here if needed on the init function:
https://stackoverflow.com/questions/43712979/how-to-export-a-symbol-from-a-rust-executable