Always load .roc files with an explicit align 16 #5771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is potentially relevant in the future when parsing with SIMD.
folkertdev
requested changes
Aug 20, 2023
| // vec now owns the allocated memory and will deallocate it when dropped. | ||
| // We set the vec's length to be file_len because we're about to read_exact that | ||
| // many bytes into it. | ||
| let mut vec = unsafe { Vec::from_raw_parts(buffer_ptr, file_len, file_len) }; |
There was a problem hiding this comment.
based on https://doc.rust-lang.org/std/vec/struct.Vec.html#method.from_raw_parts, this is UB.
You cannot have a rust Vec<T> with an allocation whose alignment is different from the alignment of T. When rust drops this vector, it only know the alignment of T, which does not match the alignment of the allocation.
also, should we not be using mmap to load files into memory?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is potentially relevant in the future when parsing with SIMD.
Also, this centralizes the file loading logic before we parse, which is nice.