Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script for updating rust version #5751

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

ziutech
Copy link

@ziutech ziutech commented Aug 11, 2023

@ziutech
Copy link
Author

ziutech commented Aug 11, 2023

One problem I see is that lines in created file end with to \n\r and I'm not sure why. Does roc always treat "\n" as \n\r or is it something in basic-cli?

@Anton-4 Anton-4 self-assigned this Aug 12, 2023
@Anton-4
Copy link
Collaborator

Anton-4 commented Aug 12, 2023

Thanks @ziutech, I'll take a look :)

@Anton-4
Copy link
Collaborator

Anton-4 commented Aug 12, 2023

I've looked at this a bit but got caught up with the basic-cli 0.5.0 release. I'll try to finish my review on monday.

@Anton-4
Copy link
Collaborator

Anton-4 commented Aug 14, 2023

The code looks good @ziutech :) I've played around with a bunch of things to try to create the perfect roc script :p
I've also upgraded the code to basic-cli 0.5.

I've left some suggestions for optional further improvements.
Feel free to continue implementing the next steps if you'd like.

We can continue working in this PR, let me know if you'd no longer be available to work on this, then we can merge in what we have.

@ziutech
Copy link
Author

ziutech commented Aug 14, 2023

I'll happily continue writing this script :)

About finding the latest nightly I was thinking if we could do a binary search between OLD_DATE and current date? Or is it better to just search linearly?

@Anton-4
Copy link
Collaborator

Anton-4 commented Aug 16, 2023

Good question! I think the best compromise would be to clone the rust-overlay repo: git clone --depth 1 https://github.com/oxalica/rust-overlay.git (to prevent lots of http requests) and then linearly go over the files. The speedup from a binary search is probably not worth the added complexity.

@ziutech
Copy link
Author

ziutech commented Aug 23, 2023

@Anton-4 Where should I clone the rust-overlay to? I was thinking of adding it to .gitignore and then just pulling the changes, instead of cloning it everytime.

@Anton-4
Copy link
Collaborator

Anton-4 commented Aug 25, 2023

Just the current directory is fine. There's no need to try to get only the changes, with '-d 1' it will already be very fast. I would remove the repo's directory as part of the script once you have the necessary date.

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Thank you for your contribution! Sometimes PRs end up staying open for a long time without activity, which can make the list of open PRs get long and time-consuming to review. To keep things manageable for reviewers, this bot automatically closes PRs that haven’t had activity in 60 days. This PR hasn’t had activity in 30 days, so it will be automatically closed if there is no more activity in the next 30 days. Keep in mind that PRs marked Closed are not deleted, so no matter what, the PR will still be right here in the repo. You can always access it and reopen it anytime you like!

Copy link

github-actions bot commented Nov 7, 2023

Thank you for your contribution! Sometimes PRs end up staying open for a long time without activity, which can make the list of open PRs get long and time-consuming to review. To keep things manageable for reviewers, this bot automatically closes PRs that haven’t had activity in 60 days. This PR hasn’t had activity in 30 days, so it will be automatically closed if there is no more activity in the next 30 days. Keep in mind that PRs marked Closed are not deleted, so no matter what, the PR will still be right here in the repo. You can always access it and reopen it anytime you like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants