-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
script for updating rust version #5751
base: main
Are you sure you want to change the base?
Conversation
One problem I see is that lines in created file end with to |
Thanks @ziutech, I'll take a look :) |
I've looked at this a bit but got caught up with the basic-cli 0.5.0 release. I'll try to finish my review on monday. |
The code looks good @ziutech :) I've played around with a bunch of things to try to create the perfect roc script :p I've left some suggestions for optional further improvements. We can continue working in this PR, let me know if you'd no longer be available to work on this, then we can merge in what we have. |
I'll happily continue writing this script :) About finding the latest nightly I was thinking if we could do a binary search between OLD_DATE and current date? Or is it better to just search linearly? |
Good question! I think the best compromise would be to clone the rust-overlay repo: |
@Anton-4 Where should I clone the rust-overlay to? I was thinking of adding it to .gitignore and then just pulling the changes, instead of cloning it everytime. |
Just the current directory is fine. There's no need to try to get only the changes, with '-d 1' it will already be very fast. I would remove the repo's directory as part of the script once you have the necessary date. |
Thank you for your contribution! Sometimes PRs end up staying open for a long time without activity, which can make the list of open PRs get long and time-consuming to review. To keep things manageable for reviewers, this bot automatically closes PRs that haven’t had activity in 60 days. This PR hasn’t had activity in 30 days, so it will be automatically closed if there is no more activity in the next 30 days. Keep in mind that PRs marked |
Thank you for your contribution! Sometimes PRs end up staying open for a long time without activity, which can make the list of open PRs get long and time-consuming to review. To keep things manageable for reviewers, this bot automatically closes PRs that haven’t had activity in 60 days. This PR hasn’t had activity in 30 days, so it will be automatically closed if there is no more activity in the next 30 days. Keep in mind that PRs marked |
#5691